Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalizer for propagation policy #4836

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add finalizer for propagation policy #4836

merged 1 commit into from
Apr 18, 2024
+72 −30

Conversation

whitewindmills
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
See #4743 (comment)
Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 16, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@whitewindmills
Copy link
Member Author

/cc @RainbowMango to take a look.

@whitewindmills whitewindmills mentioned this pull request Apr 16, 2024
Merged
@whitewindmills whitewindmills force-pushed the policy-finalizer branch 3 times, most recently from e6fa7d2 to 6f2770e Compare April 16, 2024 11:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 53.07%. Comparing base (fdad87e) to head (6f2770e).

Files Patch % Lines
pkg/detector/detector.go 0.00% 38 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4836      +/-   ##
==========================================
- Coverage   53.11%   53.07%   -0.05%     
==========================================
  Files         250      250              
  Lines       20351    20369      +18     
==========================================
  Hits        10810    10810              
- Misses       8824     8842      +18     
  Partials      717      717
Flag Coverage Δ
unittests 53.07% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitewindmills
Copy link
Member Author

/cc @RainbowMango @XiShanYongYe-Chang

@RainbowMango
Copy link
Member

/assign

RainbowMango
RainbowMango reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

pkg/detector/detector.go Outdated Show resolved Hide resolved
pkg/detector/detector.go Outdated Show resolved Hide resolved
pkg/detector/detector.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@RainbowMango
Copy link
Member

LGTM
@XiShanYongYe-Chang @chaunceyjiang
Do you guys have any further comments?

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
chaunceyjiang
chaunceyjiang reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

RainbowMango
RainbowMango approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@karmada-bot karmada-bot merged commit 1754e73 into karmada-io:master Apr 18, 2024
12 checks passed
@whitewindmills whitewindmills deleted the policy-finalizer branch April 19, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

Assignees

@RainbowMango RainbowMango

@chaunceyjiang chaunceyjiang

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@whitewindmills @codecov-commenter @RainbowMango @karmada-bot @chaunceyjiang @XiShanYongYe-Chang